Description

Fixes #1950.

The hub test suite intermittently panics on Apple Silicon during go test ./internal/alerts/... with a nil pointer dereference inside PocketBase's RecordQuery. The trace ends in StartUpdater -> setDown -> getRecord -> FindRecordById, with the goroutine created by SystemManager.AddSystem.

Root cause

SystemManager.Initialize spawns a background goroutine that walks the systems loaded from the database and calls AddSystem for each one with a time.Sleep between calls (up to 2s per system). When a test's defer hub.Cleanup() runs while that loop is still sleeping, the loop is not aware of the shutdown:

1. RemoveAllSystems iterates sm.systems.GetAll() and cancels every system already added.
2. TestApp.Cleanup calls ResetBootstrapState, nilling the underlying DB.
3. The staggered loop wakes from its sleep, calls AddSystem for the next system, and starts a StartUpdater goroutine whose sys.manager.hub already has a nil DB. The first update() call inevitably fails (no real agent), setDown -> getRecord -> FindRecordById then panics inside app.ConcurrentDB().

The window is much wider on Apple Silicon because of weaker memory ordering and slower TCP teardown, which is why x86_64 builds usually pass.

Fix

Give SystemManager its own context.Context that is cancelled on shutdown:

• The staggered Initialize loop replaces time.Sleep(sleepTime) with a select on sm.ctx.Done() and returns early once shutdown is signalled.
• AddSystem refuses to add a system (and therefore does not spawn StartUpdater) once sm.ctx is cancelled.
• The test-only RemoveAllSystems helper cancels sm.ctx before tearing systems down, so by the time TestApp.Cleanup clears the DB the staggered loop is guaranteed not to start any new updaters.

No recover() is added; the production paths are unchanged on the happy path.

Before / After

Before (from the issue, also reproducible locally on darwin/arm64):

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0xb0]
goroutine N [running]:
github.com/pocketbase/pocketbase/core.(*BaseApp).RecordQuery(...)
github.com/henrygd/beszel/internal/hub/systems.(*System).getRecord(...)
github.com/henrygd/beszel/internal/hub/systems.(*System).setDown(...)
github.com/henrygd/beszel/internal/hub/systems.(*System).StartUpdater(...)
created by github.com/henrygd/beszel/internal/hub/systems.(*SystemManager).AddSystem
FAIL    github.com/henrygd/beszel/internal/alerts

After: go test ./internal/alerts/... ./internal/hub/systems/... is green across 5 consecutive runs on darwin/arm64.

Changelog

Fixed

• Hub system manager no longer starts StartUpdater goroutines against a hub that is being torn down, fixing a flaky panic in internal/alerts tests on Apple Silicon ([Bug]: Panic / Nil pointer dereference in internal/hub/systems/system.go during tests #1950).